code-refactor #15

Merged

mhahl-a merged 4 commits from code-refactor into main 2026-08-18 07:08:12 +00:00

Conversation 0 Commits 4 Files changed 109 +2441 -2039

mhahl-a commented 2026-08-17 10:21:53 +00:00

Owner

Copy link

No description provided.

mhahl-a added 2 commits 2026-08-17 10:21:53 +00:00

chore: make the tree mypy and ruff-clean; enforce-ready ... 95b5978b82

- mypy: fix 5 real type bugs (mixed secret-value pair type, None vs str
  annotate, expires_days None guard, missing list annotation); repo now
  typechecks clean (make typecheck passes)
- ruff: auto-fix 300+ lint findings (unused imports, missed deletions,
  semicolons, percent-format, yield-from); drop dead helper re-exports in
  routes/auth|eso|mgmt_api|secrets __init__; keep intentional package
  re-exports (bearer_hash/bearer_raw) marked # noqa: F401
- ruff format on touched files (project quotes are double per pyproject)
- pylint improves to 10.00/10; full suite 438 passed

refactor: simplify error/exception layer and split RBAC routes ... 2645a9f406

- Remove secret_svc SecretError/SecretOperationError hierarchy; commands raise
  werkzeug Forbidden/NotFound and drop the except->wrap that masked real errors
- Extract db.team() and paging.paged_rows(); apply to team lookups and the
  projects/machines paginated lists
- Split routes/rbac.py into a package (helpers, roles, bindings, review)
- Rename routes/project_io.py -> import_export.py to match its content

mhahl-a added 1 commit 2026-08-18 06:50:52 +00:00

chore: dedupe color-picker JS and secret-mutation redirect tail ... 0e187e2cc3

- Extract shared color-picker JS into partials/color_picker_js.html;
  used by both settings_banner and team_settings
- Extract _secrets_redirect_or_partial() in secrets/helpers.py for
  the duplicated HTMX-partial-or-redirect tail in crud create/delete

mhahl-a added 1 commit 2026-08-18 07:04:03 +00:00

feat(settings): move clipboard/reveal UX knobs to server settings ... 764298792d

- clipboard_clear_seconds, reveal_auto_hide_seconds, reveal_access_grant_minutes
  are now DB-backed server settings (Settings -> General), no longer env vars
- add settings_svc.int_setting()/reveal_access_grant_minutes() accessors and
  rewire all consumers (nav context, reveal render, grant windows)
- keep DB/Redis/crypto/bootstrap/DoS-guard config as env (deploy-bound)

mhahl-a merged commit a706d62170 into main 2026-08-18 07:08:12 +00:00

mhahl-a referenced this pull request from a commit 2026-08-18 07:08:12 +00:00

Merge pull request 'code-refactor' (#15) from code-refactor into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Sigaint/corvus!15

No description provided.